Add favicon tags #761
Merged
Add favicon tags #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds favicon support by introducing a new partial view and updating the head layout accordingly.
- Inserts a partial call in the head layout to render favicon tags.
- Removes an unused configuration property from the htmx meta tag.
- Adds a new partial view containing various favicon link tags.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Elastic.Markdown/Slices/Layout/_Head.cshtml | Updates head layout to render favicon partial and simplifies the htmx meta tag. |
| src/Elastic.Markdown/Slices/Layout/_Favicon.cshtml | Introduces a new partial view with multiple favicon link declarations. |
reakaleek
commented
Mar 17, 2025
| <meta name="robots" content="@(Model.AllowIndexing ? "index, follow" : "noindex, nofollow")"> | ||
| <meta name="htmx-config" content='{"scrollIntoViewOnBoost": false, "selfRequestsOnly": true}'> |
There was a problem hiding this comment.
Unrelated change: We are not using boosted links. Hence, this config option is not necessary.
Mpdreamz
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
One of those "It bugs me, it should be fast to implement" issues that somehow still always ends up at the bottom of the priority queue.
Thank you @reakaleek for getting it of our queue! 😸
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.