Move to docs-builder with support for nested toc.yml files #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
reakaleek
previously approved these changes
Jan 27, 2025
.vscode/tasks.json
Outdated
| { | ||
| "label": "Serve Documentation", | ||
| "type": "shell", | ||
| "command": "docker run -v \"./.git:/app/.git\" -v \"./docs:/app/docs\" -v \"./.artifacts:/app/.artifacts\" --platform linux/amd64 -p 8080:8080 ghcr.io/elastic/docs-builder:edge serve", |
There was a problem hiding this comment.
Should this be -p 3000:3000 now?
There was a problem hiding this comment.
Removed these for now while I investigate how to best expose these.
Given the repository layout we need different mount strategy
docker run -v "./.git:/app/.git" -v ".:/app/docs" -v "./.artifacts:/app/.artifacts" -p 3000:3000 --expose 3000 ghcr.io/elastic/docs-builder:edge --force
Yields a few errors we need to address in docs-builder after we merge this.
reakaleek
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.