-
Notifications
You must be signed in to change notification settings - Fork 108
apm-server: Remove server information endpoint POST /
support
#647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apm-server: Remove server information endpoint POST /
support
#647
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hold off from merging
% :::: | ||
|
||
::::{dropdown} Change server information endpoint / to only accept GET and HEAD requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In release-notes markdown, there's a comment
% Release notes include only features, enhancements, and fixes. Add breaking changes, deprecations, and known issues to the applicable release notes sections.
% For each new version section, include the Elastic APM and Kibana changes.
[to reviewer] so we're not supposed to mention breaking changes in release notes changelog, but only in this breaking changes section from now on? Asking as this is kind of different from what we did in <9.0. Also, there's no links to breaking changes from 9.0 release notes. I wonder if users would miss any breaking changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From @KOTungseth:
Correct—the new structure separates breaking changes from the release notes changelog. Moving forward, breaking changes should only be documented in the "Breaking Changes" section, not in the general release notes. Since breaking changes appear in the left nav in the release notes section of our new IA [this is just a subset of release-note-related content as we wait for the dev work to be done related to assembling docs from all repos together], users can easily navigate and view these pages.
@KOTungseth can you share a link to more details about the release note strategy with @carsonip when it's ready? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@colleenmcginnis sgtm. I believe this PR aligns with the strategy. Feel free to review and merge it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions below.
Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Co-authored-by: Colleen McGinnis <[email protected]>
Corresponding code change: elastic/apm-server#15976 Issue elastic/apm-server#15965
Corresponding code change: elastic/apm-server#15976
Issue elastic/apm-server#15965