Remove unused links from docset.yml and fix links #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bmorelli25 <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR removes a large number of unused and outdated links from the docset configuration and fixes link formatting issues in several markdown documentation files.
- Removed obsolete links from docset.yml to streamline the documentation source.
- Updated rollover API link formatting in fleet data streams scenario documents.
- Revised the Sysmon integration link in the auditbeat migration guide for improved clarity.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docset.yml | Removed multiple unused/outdated link entries to simplify the docset configuration. |
| reference/ingestion-tools/fleet/data-streams-scenario1.md | Fixed rollover API link formatting to use explicit URLs. |
| reference/ingestion-tools/fleet/data-streams-scenario2.md | Corrected rollover API link formatting with explicit markdown links. |
| reference/ingestion-tools/fleet/migrate-auditbeat-to-agent.md | Updated the Sysmon integration link for clarity in reference documentation. |
Comments suppressed due to low confidence (2)
docset.yml:66
- Ensure that the removal of unused links (such as the functionbeat-ref entry) does not break any existing references within the documentation.
- functionbeat-ref: "https://www.elastic.co/guide/en/beats/functionbeat/current"
reference/ingestion-tools/fleet/data-streams-scenario1.md:76
- The use of the placeholder '{{es}}' before the rollover API link may lead to unresolved values; consider verifying that this placeholder is intended or removing it if not needed.
New ILM policies only take effect when new indices are created, so you either must wait for a rollover to occur (usually after 30 days or when the index size reaches 50 GB), or force a rollover of each data stream using the {{es}} [rollover API](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-rollover).
Comment on lines
+72
to
73
| New ILM policies only take effect when new indices are created, so you either must wait for a rollover to occur (usually after 30 days or when the index size reaches 50 GB), or force a rollover of the data stream using the {{es}} [rollover API](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-rollover): | ||
|
|
There was a problem hiding this comment.
Similarly, the '{{es}}' placeholder before the rollover API link should be checked to ensure it renders as intended or is removed for clarity.
Suggested change
| New ILM policies only take effect when new indices are created, so you either must wait for a rollover to occur (usually after 30 days or when the index size reaches 50 GB), or force a rollover of the data stream using the {{es}} [rollover API](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-rollover): | |
| New ILM policies only take effect when new indices are created, so you either must wait for a rollover to occur (usually after 30 days or when the index size reaches 50 GB), or force a rollover of the data stream using the [Elasticsearch](https://www.elastic.co/guide/en/elasticsearch/reference/current) [rollover API](https://www.elastic.co/docs/api/doc/elasticsearch/operation/operation-indices-rollover): |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
I appreciate the suggestion, but no.
thekofimensah
pushed a commit
that referenced
this pull request
Mar 21, 2025
Signed-off-by: bmorelli25 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.