-
Notifications
You must be signed in to change notification settings - Fork 106
Adds applies_to tags to Troubleshoot > Elastic Cloud #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to not block this because the issues are kind of not strictly related to the applies to tags, but I believe these should be fixed before we go live to avoid misleading or confusing users.
@@ -1,5 +1,7 @@ | |||
--- | |||
navigation_title: "Elastic Serverless Forwarder" | |||
applies_to: | |||
serverless: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this tool is misleading, it doesn't have anything to do with our own Serverless offering. See https://www.elastic.co/guide/en/esf/current/aws-elastic-serverless-forwarder.html
This page should be under Troubleshooting > ingest tools. And applies_to
should be stack: all and serverless: all
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of that, thanks @florent-leborgne! cc @marciw
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natasha-moore-elastic @florent-leborgne thank you both -- I can handle this in a separate PR
deployment: | ||
ess: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This page should have an equivalent in the Elastic Cloud Enterprise section (it's even in the mapped page of this file), but I'm not seeing it in the preview. If you choose to duplicate + adjust it for ECE, then no need to change the applies_to tags for this one. But in the meantime or if treated separately/later, maybe we could just add "ece: all" as well here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @marciw I could be misremembering, but I think we worked on consolidating these duplicates intentionally? If that's the case and we don't plan on having a separate ECE topic, then I'll go ahead and add the ece:all
label, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@natasha-moore-elastic eek, I think this is a byproduct of a change in the structure early on...
I'd say go ahead and add ece:all
here and we can revisit shortly afterward
deployment: | ||
ess: all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as before, this page should also have an ECE equivalent.
Follow up on issues raised in #880 (thank you again @florent-leborgne!) TODO: create issue to reconsolidate later
Adds applies_to tags to the Troubleshoot > Elastic Cloud section.
Preview: Elastic Cloud