-
Notifications
You must be signed in to change notification settings - Fork 345
Copy images from unordeed and definition lists #1093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We had support for copying images within ordered lists but not within *un*ordered lists. This fixes that.
@haywoood, do you have time to look at this one? |
There is more to do here..... |
I think I've got it now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍔
@elasticmachine, run elasticsearch-ci/docs rebuild I want to make super sure this is ok on all the books, just in case. |
@elasticmachine, run elasticsearch-ci/docs rebuild |
The failure here is real! I'm tracking it down. Weird stuff. |
OK! I discovered the issue here. The mechanism that I was using to resolve attributes is wrong. I was replaying "my" attributes but if the attributes are set "far enough" from where they are used they aren't found. I'll have to rework a bunch of stuff to get this working.... |
@elasticmachine, run elasticsearch-ci/docs rebuild |
OK! The solution that I have here doesn't crash and passes the tests I could come up with so it might be better than what we had. I'm going to go over the diff later and see if I can find any images it didn't copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@haywoood, I think this is ready! It is quite different, but it has to be to pick up images properly. I think this pattern will ultimately simplify how I plug in to Asciidoctor.
@@ -0,0 +1,30 @@ | |||
# frozen_string_literal: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This class is the real magic in this PR: instead of plugging in to asciidoctor using its plugin mechanism this plugs in using the "converter". This allows us to plug whatever behavior we need in at render time when the attributes are properly resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍔
@elasticmachine, run elasticsearch-ci/docs rebuild |
Just for extra paranoia.... |
🍟 |
We had support for copying images within ordered lists but not within
unordered lists. This fixes that.