Skip to content

Update ES clients to use stackcurrent and stacklivemain variables #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2022
Merged

Update ES clients to use stackcurrent and stacklivemain variables #2385

merged 2 commits into from
Feb 28, 2022

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Feb 25, 2022

Updates the following ES clients docs to use the stackcurrent and stacklivemain variables:

  • Java
  • JavaScript
  • Ruby
  • Go
  • .NET
  • PHP
  • Python

This will bump the current branch for these docs to 8.0. It'll also ensure the clients stay synced with stack releases in the future.

This does not update the current version for the Perl or Rust clients.

@jrodewig jrodewig requested review from philkra and gtback February 25, 2022 14:51
@jrodewig jrodewig changed the title Update current version for ES clients Update current version for ES clients to 8.0 Feb 25, 2022
Copy link
Contributor

@philkra philkra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I double checked the repos and the branches are in place. Thanks James for opening the PR

@jrodewig
Copy link
Contributor Author

This change is causing some links from the legacy elasticsearch.js docs to the ES JS client docs to break. To fix those links, I've opened elastic/elasticsearch-js#1634 to add some related redirects. I've also reached out to the clients team about updating the legacy docs.

We should also investigate whether we can use the stackcurrent and stacklivemain variables for these client docs instead of hardcoding the current and live branches. I'll reach out to the clients team about this on Monday.

@jrodewig jrodewig changed the title Update current version for ES clients to 8.0 Update ES clients to use stackcurrent and stacklivemain variables Feb 28, 2022
@jrodewig
Copy link
Contributor Author

I spoke with @philkra and confirmed that we can use the stackcurrent and stacklivemain variables.

I'll merge this in once elastic/elasticsearch-js#1634 is merged and backported.

@philkra
Copy link
Contributor

philkra commented Feb 28, 2022

Thanks @jrodewig , the PR elastic/elasticsearch-js#1634 is merged on main

@gtback
Copy link
Member

gtback commented Feb 28, 2022

@elasticmachine run elasticsearch-ci/docs

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the builds pass.

@jrodewig
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@jrodewig jrodewig merged commit 7ff2e1d into elastic:master Feb 28, 2022
@jrodewig jrodewig deleted the update-es-client-curret branch February 28, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants