Skip to content

Set Buildkite PR job to use master and add batch1 of repos #2837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Nov 21, 2023

This PR that goes hand in hand with this one hooks up a few more products-docs repositories to Buildkite. On such repos, when a PR is opened or commented on (with run docs-build), the docs-build-pr job will be triggered (alongside it's Jenkins counterpart), and push preview changes to the elastic/built-docs repo under the <doc>_bk_<PR_NUMBER> branch name.

Commit statuses for the Buildkite build will be set but they are not configured to be blocking.
Additionally, the Buildkite job is configured to report back on the PR with a link to the preview and diff reports. Here's an example of such comment.

The intent in the coming days is to gain confidence in the Jenkins VS Buildkite PR docs job.

cc @brianseeders @mark-vieira for the elasticsearch repo
cc @delanni for the kibana repo
cc @thbkrkr for cloud-on-k8s
cc @kilfoyle for ingest-docs
cc @v1v / @jlind23 for beats
cc @natasha-moore-elastic for security-docs
cc @pquentin for elasticsearch-py

@elasticmachine
Copy link

💚 Build Succeeded

History

@nkammah
Copy link
Contributor Author

nkammah commented Nov 25, 2023

cc @brianseeders @mark-vieira I disabled the Buildkite PR bot commenting to avoid conflicts with other pipelines. Product repos longing for that commenting capability can set a GH action similar to this one or this one which can be tailored to each repo.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, but I'd want to make sure all the content owners are aware of this change.

@joepeeples
Copy link
Contributor

I disabled the Buildkite PR bot commenting to avoid conflicts with other pipelines. Product repos longing for that commenting capability can set a GH action similar to this one or this one which can be tailored to each repo.

@nkammah @gtback etc. We have a similar GitHub action for the security-docs repo, so it sounds like we'll need to modify that to include the Buildkite URLs — is that correct?

Also, how long will we continue to have both Buildkite and Jenkins running on docs PRs? Because I assume once we stop using Jenkins, we'd need to modify our GH action again to remove the Jenkins preview URLs.

@nkammah
Copy link
Contributor Author

nkammah commented Nov 28, 2023

Also, how long will we continue to have both Buildkite and Jenkins running on docs PRs? Because I assume once we stop using Jenkins, we'd need to modify our GH action again to remove the Jenkins preview URLs.

Yes for now we will have both running to gain confidence in the Buildkite setup - we'll also need your help to validate that setup. We do need to move forward promptly as the docs jobs on elasticsearch-ci is what's holding that Jenkins instance decomissioning date.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the ingest docs. 👍

@nkammah
Copy link
Contributor Author

nkammah commented Nov 28, 2023

I disabled the Buildkite PR bot commenting to avoid conflicts with other pipelines. Product repos longing for that commenting capability can set a GH action similar to this one or this one which can be tailored to each repo.

@nkammah @gtback etc. We have a similar GitHub action for the security-docs repo, so it sounds like we'll need to modify that to include the Buildkite URLs — is that correct?

Ha yes - touché !

Also, how long will we continue to have both Buildkite and Jenkins running on docs PRs? Because I assume once we stop using Jenkins, we'd need to modify our GH action again to remove the Jenkins preview URLs.

I'm hoping not much time - a week? 2?

@brianseeders
Copy link

Does @elastic/ci-systems have monitoring in place for github api request rate limiting for elasticmachine? I would say it would be good to have in place before you start rolling this out, as the pr-bot will start using more API requests for each additional repo

@nkammah
Copy link
Contributor Author

nkammah commented Nov 28, 2023

@brianseeders - yes it's here per doc

@nkammah nkammah merged commit 39c83fd into master Nov 28, 2023
@nkammah nkammah deleted the buildkite-pr-repos-batch1 branch November 28, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants