-
Notifications
You must be signed in to change notification settings - Fork 345
Set Buildkite PR job to use master and add batch1 of repos #2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @brianseeders @mark-vieira I disabled the Buildkite PR bot commenting to avoid conflicts with other pipelines. Product repos longing for that commenting capability can set a GH action similar to this one or this one which can be tailored to each repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, but I'd want to make sure all the content owners are aware of this change.
@nkammah @gtback etc. We have a similar GitHub action for the Also, how long will we continue to have both Buildkite and Jenkins running on docs PRs? Because I assume once we stop using Jenkins, we'd need to modify our GH action again to remove the Jenkins preview URLs. |
Yes for now we will have both running to gain confidence in the Buildkite setup - we'll also need your help to validate that setup. We do need to move forward promptly as the docs jobs on elasticsearch-ci is what's holding that Jenkins instance decomissioning date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the ingest docs. 👍
Ha yes - touché !
I'm hoping not much time - a week? 2? |
Does @elastic/ci-systems have monitoring in place for github api request rate limiting for |
@brianseeders - yes it's here per doc |
This PR that goes hand in hand with this one hooks up a few more products-docs repositories to Buildkite. On such repos, when a PR is opened or commented on (with
run docs-build
), the docs-build-pr job will be triggered (alongside it's Jenkins counterpart), and push preview changes to theelastic/built-docs
repo under the<doc>_bk_<PR_NUMBER>
branch name.Commit statuses for the Buildkite build will be set but they are not configured to be blocking.
Additionally, the Buildkite job is configured to report back on the PR with a link to the preview and diff reports. Here's an example of such comment.
The intent in the coming days is to gain confidence in the Jenkins VS Buildkite PR docs job.
cc @brianseeders @mark-vieira for the elasticsearch repo
cc @delanni for the kibana repo
cc @thbkrkr for cloud-on-k8s
cc @kilfoyle for ingest-docs
cc @v1v / @jlind23 for beats
cc @natasha-moore-elastic for security-docs
cc @pquentin for elasticsearch-py