Skip to content

Add feedback widget to docs sidebar #2838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2023

Conversation

scottybollinger
Copy link
Contributor

@scottybollinger scottybollinger commented Nov 21, 2023

Closes https://github.com/elastic/docsmobile/issues/697

This PR adds a feedback widget to the end of the right sidebar. This mimics the feedback experience that exists on https://docs.elastic.co.

Here is a video of the experience:

feedback.mp4

Notes:

  • Because of the need for shared state but different locations in the markup (modal needs to be outside of the content and the widget in the sidebar), I opted to maintain all state in the modal component and use JavaScript to alter class names in the widget. The codebase contains redux, but I thought it overkill to wire up a solution that shares state as the need in the widget is minimal.

@scottybollinger scottybollinger changed the title Scottybollinger/feedback widget Add feedback widget to docs sidebar Nov 21, 2023
@scottybollinger scottybollinger marked this pull request as ready for review November 21, 2023 18:47
Copy link
Contributor

@glitteringkatie glitteringkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow it's been a while since I've seen react like this! Great job!

@elasticmachine
Copy link

💔 Build Failed

Failed CI Steps

History

@scottybollinger
Copy link
Contributor Author

💔 Build Failed

Failed CI Steps

History

@nkammah can you tell me how to determine why this failed? Clicking on the link doesn't tell much and I've tried parsing the console output and nothing indiciates why there was a failure.

@scottybollinger scottybollinger merged commit ab39cfc into master Nov 21, 2023
@scottybollinger scottybollinger deleted the scottybollinger/feedback-widget branch November 21, 2023 20:13
@nkammah
Copy link
Contributor

nkammah commented Nov 21, 2023

@scottybollinger if you look all the way at the bottom of the build page, you'll see

Exited with status -1 (agent lost)
image

This means that the build agent ran out of resources (cpu/memory) and the build was interrupted.
I am trying to fine tune the values and speed up the build into another PR.

Note that this is the first time I see this type of failure on the docs repo :(

@nkammah
Copy link
Contributor

nkammah commented Nov 21, 2023

Alternatively - it could be due to Buildkite having issues as posted to their status page: https://www.buildkitestatus.com/

image

@scottybollinger
Copy link
Contributor Author

Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants