Fix skiplinkcheck #638
Merged
Fix skiplinkcheck #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`--skiplinkcheck` and `--linkcheckonly` were documented as only working with `--doc` but they are actually only used with `--all`. This fixes the documentation and the preflight checks to reflect that reality.
|
Good catch! Makes sense, since we only do the link checks on --all |
I bumped into this yesterday when I tried to skip the links check! |
ddillinger
approved these changes
Feb 25, 2019
|
Thanks for looking @ddillinger and @lcawl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--skiplinkcheckand--linkcheckonlywere documented as only workingwith
--docbut they are actually only used with--all. This fixesthe documentation and the preflight checks to reflect that reality.