Use more standard rspec in cramped include spec #792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the more junit like tests in the cramped include spec with descriptive contexts which is more idiomatic rspec.
nik9000
commented
Apr 4, 2019
| @@ -8,7 +8,6 @@ | |||
| before(:each) do | |||
| Asciidoctor::Extensions.register do | |||
| preprocessor CrampedInclude | |||
| preprocessor ElasticCompatPreprocessor | |||
estolfo
reviewed
Apr 8, 2019
| it 'renders both callout lists' do | ||
| expect(converted).to include('<callout arearefs="CO1-1">') | ||
| .and(include('<callout arearefs="CO2-1">')) | ||
| end |
There was a problem hiding this comment.
Is there a reason you didn't write it like the following?
expect(converted).to include('<callout arearefs="CO1-1">')
expect(converted).to include('<callout arearefs="CO2-1">')There was a problem hiding this comment.
I suppose the error message is a little more descriptive the way I have it, but not much. Either way is fine by me. If you prefer your way I'll switch it.
There was a problem hiding this comment.
It's pretty minor, so whatever makes most sense to you.
|
Thanks for reviewing @estolfo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the more junit like tests in the cramped include spec with
descriptive contexts which is more idiomatic rspec.