Skip to content

Commit e8ea283

Browse files
committed
Switch to build tools git processing logic (#1472)
1 parent 47d4a62 commit e8ea283

File tree

3 files changed

+5
-49
lines changed

3 files changed

+5
-49
lines changed

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/BaseBuildPlugin.groovy

Lines changed: 0 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -148,10 +148,6 @@ class BaseBuildPlugin implements Plugin<Project> {
148148
if (!project.rootProject.ext.has('settingsConfigured')) {
149149
// Force any Elasticsearch test clusters to use packaged java versions if they have them available
150150
project.rootProject.ext.isRuntimeJavaHomeSet = false
151-
152-
File gitHead = gitBranch(project)
153-
project.rootProject.ext.gitHead = gitHead
154-
project.rootProject.ext.revHash = gitHash(gitHead)
155151
project.rootProject.ext.settingsConfigured = true
156152

157153
// TODO: Forward Port?
@@ -163,8 +159,6 @@ class BaseBuildPlugin implements Plugin<Project> {
163159
// params.setIsRutimeJavaHomeSet(project.rootProject.ext.isRuntimeJavaHomeSet)
164160
// }
165161
}
166-
project.ext.gitHead = project.rootProject.ext.gitHead
167-
project.ext.revHash = project.rootProject.ext.revHash
168162
project.ext.javaVersions = BuildParams.javaVersions
169163
project.ext.isRuntimeJavaHomeSet = project.rootProject.ext.isRuntimeJavaHomeSet
170164
}
@@ -216,44 +210,4 @@ class BaseBuildPlugin implements Plugin<Project> {
216210
}
217211
// End section
218212
}
219-
220-
/**
221-
* @param project that belongs to a git repo
222-
* @return the file containing the hash for the current branch
223-
*/
224-
private static File gitBranch(Project project) {
225-
// parse the git files to find out the revision
226-
File gitHead = project.file("${project.rootDir}/.git/HEAD")
227-
if (gitHead != null && !gitHead.exists()) {
228-
// Try as a sub module
229-
File subModuleGit = project.file("${project.rootDir}/.git")
230-
if (subModuleGit != null && subModuleGit.exists()) {
231-
String content = subModuleGit.text.trim()
232-
if (content.startsWith("gitdir:")) {
233-
gitHead = project.file("${project.rootDir}/" + content.replace('gitdir: ','') + "/HEAD")
234-
}
235-
}
236-
}
237-
238-
if (gitHead != null && gitHead.exists()) {
239-
String content = gitHead.text.trim()
240-
if (content.startsWith("ref:")) {
241-
return project.file("${project.rootDir}/.git/" + content.replace('ref: ',''))
242-
}
243-
return gitHead
244-
}
245-
return null
246-
}
247-
248-
/**
249-
* @param gitHead file containing the the currently checked out ref
250-
* @return the current commit version hash
251-
*/
252-
private static String gitHash(File gitHead) {
253-
String rev = "unknown"
254-
if (gitHead != null && gitHead.exists()) {
255-
rev = gitHead.text.trim()
256-
}
257-
return rev
258-
}
259213
}

buildSrc/src/main/groovy/org/elasticsearch/hadoop/gradle/BuildPlugin.groovy

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package org.elasticsearch.hadoop.gradle
22

33
import org.elasticsearch.gradle.DependenciesInfoTask
4+
import org.elasticsearch.gradle.info.BuildParams
45
import org.elasticsearch.gradle.precommit.DependencyLicensesTask
56
import org.elasticsearch.gradle.precommit.LicenseHeadersTask
67
import org.elasticsearch.gradle.precommit.UpdateShasTask
@@ -231,7 +232,7 @@ class BuildPlugin implements Plugin<Project> {
231232
manifest.attributes['Implementation-URL'] = "https://github.com/elastic/elasticsearch-hadoop"
232233
manifest.attributes['Implementation-Vendor'] = "Elastic"
233234
manifest.attributes['Implementation-Vendor-Id'] = "org.elasticsearch.hadoop"
234-
manifest.attributes['Repository-Revision'] = project.ext.revHash
235+
manifest.attributes['Repository-Revision'] = BuildParams.gitRevision
235236
String build = System.env['ESHDP.BUILD']
236237
if (build != null) {
237238
manifest.attributes['Build'] = build

mr/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import org.elasticsearch.gradle.info.BuildParams
12

23
apply plugin: 'es.hadoop.build.integration'
34

@@ -36,13 +37,13 @@ sourceSets {
3637
}
3738

3839
task generateGitHash {
39-
inputs.file project.ext.gitHead
40+
inputs.property "revision", BuildParams.gitRevision
4041
outputs.dir generatedResources
4142

4243
doLast {
4344
Properties props = new Properties()
4445
props.put("version", version)
45-
props.put("hash", project.ext.revHash)
46+
props.put("hash", BuildParams.gitRevision)
4647
File output = new File(generatedResources, "esh-build.properties")
4748
new File(generatedResources).mkdirs()
4849
output.createNewFile()

0 commit comments

Comments
 (0)