Skip to content

Use build tools to read git revision #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2020
Merged

Use build tools to read git revision #1472

merged 1 commit into from
Jun 4, 2020

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented May 13, 2020

Remove our git revision parsing code and replace it with the parsing logic from build tools since that handles git worktrees correctly.

dakrone
dakrone approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also assuming CI is happy

@jbaiera jbaiera merged commit 4210d64 into elastic:master Jun 4, 2020
@jbaiera jbaiera deleted the use-git-from-build-tools branch June 4, 2020 18:54
jbaiera added a commit that referenced this pull request Jun 4, 2020
@jbaiera
Switch to build tools git processing logic (#1472)
e8ea283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
:Build non-issue v7.9.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbaiera @dakrone