Skip to content

Remove deprecated Gradle configurations #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Feb 13, 2020

The original Gradle configuration names of compile and runtime are deprecated. This PR replaces their uses in the build with new/current configurations.

Specifically, this PR converts uses of the compile configuration to instead use the implementation or api configurations. It also swaps the use of the runtime configuration over to use runtimeClasspath.

Did some light tidying up as well.

Switch uses of `compile` over to using `implementation` and `api`
instead. Swapped some instances of using `runtime` to use
`runtimeClasspath` as well.

Additionally do some light tidying up.
Copy link
Contributor

@danhermann danhermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jbaiera jbaiera merged commit bc65f89 into elastic:master Feb 24, 2020
@jbaiera jbaiera deleted the fix-remove-deprecated-gradle-configurations branch February 24, 2020 21:57
jbaiera added a commit that referenced this pull request May 13, 2020
Switch uses of `compile` over to using `implementation` and `api`
instead. Swapped some instances of using `runtime` to use
`runtimeClasspath` as well.

Additionally do some light tidying up.
@jbaiera
Copy link
Member Author

jbaiera commented Jul 14, 2020

Relates #1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants