Skip to content

Fix usage of the GlobalBuildInfoPlugin #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Fix usage of the GlobalBuildInfoPlugin #1453

merged 1 commit into from
Mar 26, 2020

Conversation

jbaiera
Copy link
Member

@jbaiera jbaiera commented Mar 26, 2020

This PR updates the project build plugin to use BuildParams instead of the now removed GenerateGlobalBuildInfoTask.

@jbaiera jbaiera requested a review from mark-vieira March 26, 2020 19:53
mark-vieira
mark-vieira approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@mark-vieira mark-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jbaiera jbaiera merged commit 335043e into elastic:master Mar 26, 2020
@jbaiera jbaiera deleted the fix-snapshot-build-info branch March 26, 2020 20:13
jbaiera added a commit that referenced this pull request May 13, 2020
@jbaiera
Fix usage of the GlobalBuildInfoPlugin (#1453)
4940e98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-vieira mark-vieira mark-vieira approved these changes

Assignees
No one assigned
Labels
:Build enhancement v7.8.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbaiera @mark-vieira