Use subproject to generate distribution instead of root #1463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
commented
Apr 14, 2020
jbaiera
commented
Apr 14, 2020
mark-vieira
reviewed
Apr 14, 2020
| canBeResolved = true | ||
| canBeConsumed = false | ||
| attributes { | ||
| attribute(Usage.USAGE_ATTRIBUTE, objects.named(Usage, 'packaging')) |
There was a problem hiding this comment.
Brilliant. Seems we've finally nailed down these configuration attributes to work the way we want.
Exports for javadoc generation are different from exports required for source jars because one contains only java code (including generated), and the other contains original code (java and scala, no generated java) Add scala code to the regular sources exported configurations. In scala projects that add source dirs, add the new sources to the correct configurations. Fixed a bug where javadocs were not getting all sources passed to them. Fixed header display for final distribution javadocs.
|
I think I'm good for review on this now. I left in the current root project distribution logic for now since release process depends on it. Once this is merged, I'll make the changes to release process to look at the new location for distribution artifacts, then follow up on this project to remove the old root project distribution tasks. |
jbaiera
added a commit
that referenced
this pull request
Jun 8, 2020
Created a dist project and using it to construct the zip/uberjar Add javadocSources and javadocElements configurations. Exports for javadoc generation are different from exports required for source jars because one contains only java code (including generated), and the other contains original code (java and scala, no generated java) Add scala code to the regular sources exported configurations. In scala projects that add source dirs, add the new sources to the correct configurations.
|
Relates #1423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a subproject (
dist) which collects the contents of all integrations together into the project uberjar, and the zip distribution. Currently, these are created in the root project, mostly without proper dependency modeling.Creating as Draft to collect some feedback.