Fix Scala test compile Java home usage #1481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-vieira
reviewed
Jun 4, 2020
| @@ -55,10 +55,10 @@ configurations.all { Configuration conf -> | |||
| tasks.withType(ScalaCompile) { ScalaCompile task -> | |||
| task.sourceCompatibility = project.ext.minimumRuntimeVersion | |||
| task.targetCompatibility = project.ext.minimumRuntimeVersion | |||
| task.options.forkOptions.executable = new File(project.ext.runtimeJavaHome, 'bin/java').canonicalPath | |||
There was a problem hiding this comment.
Is there a compelling reason to use canonicalPath here? There's a performance cost to doing so as resolving a canonical path involves file IO at configuration time.
There was a problem hiding this comment.
I'll put up a quick fix for this then. I was following the same approach that the Gradle internals are doing, but I suppose if they're already getting the canonical file, we don't have to here.
|
Relates #1423 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the java home property was only done on the regular Scala compile task. It should be set on all Scala compile tasks instead.