Skip to content

Using case-insensitive headers #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2021

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Sep 7, 2021

The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.
Relates #1745

@masseyke masseyke requested a review from jbaiera September 7, 2021 13:32
@masseyke masseyke linked an issue Sep 7, 2021 that may be closed by this pull request
Copy link
Member

@jbaiera jbaiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for squashing this

@masseyke masseyke merged commit 014b228 into elastic:master Sep 7, 2021
@masseyke masseyke deleted the fix/case-insensitive-headers branch September 7, 2021 15:02
masseyke added a commit to masseyke/elasticsearch-hadoop that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates elastic#1745
masseyke added a commit to masseyke/elasticsearch-hadoop that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates elastic#1745
masseyke added a commit to masseyke/elasticsearch-hadoop that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates elastic#1745
masseyke added a commit that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates #1745
masseyke added a commit that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates #1745
masseyke added a commit that referenced this pull request Sep 7, 2021
The check for the X-elastic-product header is currently case sensitive. However header names are
supposed to be case-insensitive. This commit makes the check case sensitive.

Relates #1745
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Headers are not handled in a case-insensitive way
2 participants