Set UserProvider before discovery in Spark SQL integrations #1934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
reviewed
Mar 28, 2022
| @@ -533,10 +534,10 @@ private[sql] case class ElasticsearchRelation(parameters: Map[String, String], @ | |||
|
|
|||
| // perform a scan-scroll delete | |||
| val cfgCopy = cfg.copy() | |||
| InitializationUtils.setUserProviderIfNotSet(cfgCopy, classOf[HadoopUserProvider], null) | |||
There was a problem hiding this comment.
Should we just roll setUserProviderIfNotSet into discoverClusterInfo to keep us from accidentally calling discoverClusterInfo without it in the future?
There was a problem hiding this comment.
I don't disagree, but I think the problems are rooted deeper than just this initialization call. Honestly, I think all of InitializationUtils in general needs to be reworked.
masseyke
approved these changes
Mar 28, 2022
jbaiera
added a commit
to jbaiera/elasticsearch-hadoop
that referenced
this pull request
Mar 29, 2022
…1934) This PR adds the requisite configuration step for the UserProvider implementation before attempting to discover the cluster information in the SparkSQL integrations. This additionally updates the integration tests to add coverage for the write and read paths for SparkSQL.
jbaiera
added a commit
to jbaiera/elasticsearch-hadoop
that referenced
this pull request
Mar 29, 2022
…1934) This PR adds the requisite configuration step for the UserProvider implementation before attempting to discover the cluster information in the SparkSQL integrations. This additionally updates the integration tests to add coverage for the write and read paths for SparkSQL.
This was referenced Mar 29, 2022
jbaiera
added a commit
that referenced
this pull request
Mar 30, 2022
) (#1936) This PR adds the requisite configuration step for the UserProvider implementation before attempting to discover the cluster information in the SparkSQL integrations. This additionally updates the integration tests to add coverage for the write and read paths for SparkSQL.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the requisite configuration step for the UserProvider implementation before attempting to discover the cluster information in the SparkSQL integrations. This additionally updates the integration tests to add coverage for the write and read paths for SparkSQL.
Fixes #1933