Backport java 17 build support to 7.17 #1950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for building on java 17, while leaving support for building java 11 untouched.
masseyke
changed the title
jbaiera
reviewed
Apr 25, 2022
hive/build.gradle
Outdated
| @@ -58,6 +58,12 @@ dependencies { | |||
| javadocSources(project(":elasticsearch-hadoop-mr")) | |||
| } | |||
|
|
|||
| tasks.named("test").configure { | |||
| onlyIf { JavaVersion.current() >= JavaVersion.VERSION_16 } | |||
There was a problem hiding this comment.
Is this just needed to conditionally add the jvmArgs settings or are these tests required to run on JVM 16 and up?
There was a problem hiding this comment.
This is just for the jvmArgs settings. The tests still run for all versions right?
There was a problem hiding this comment.
I think the onlyIf method marks the task to only run when the condition is true
There was a problem hiding this comment.
Wow you're right. I think I think I just messed that one up. I'll also need to fix it on master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting support for building on java 17 from #1802 and #1808