Adding a readiness check before using services in tests #2099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
approved these changes
Jun 8, 2023
| if ('HTTPS_ONLY' == hdfsSite.get('dfs.http.policy')) { | ||
| return getInetAddress(hdfsSite.getOrDefault('dfs.namenode.https-address', 'localhost:50470')) | ||
| } else { | ||
| return getInetAddress(hdfsSite.getOrDefault('dfs.namenode.https-address', 'localhost:50070')) |
There was a problem hiding this comment.
Should this be http-address instead of https-address? Looks like this and the datanode else blocks have identical code to the https case.
There was a problem hiding this comment.
Oh wow yeah. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen
:qa:kerberosfail because it tries to run hiveLoadData before the hive server is actually up. We currently only check that the pidfile exists, which really only tells us that we have asked the hive server to start and that it has not crashed. I have seen this happen with hive but it could probably happen with any service if the service for some reason was slow enough coming up. This PR makes it so that each node in each role in each service used gives us a host/port pair, and we check that that port is reachable before attempting to use the node for that role.