Skip to content

Set Spark 3.x default to Scala 2.13 #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 31, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@ class SparkYarnServiceDescriptor implements ServiceDescriptor {
@Override
String artifactName(ServiceConfiguration configuration) {
Version version = configuration.getVersion()
return "spark-$version-bin-hadoop${hadoopVersionCompatibility()}"
// artifact name: https://spark.apache.org/downloads.html
return "spark-$version-bin-hadoop${hadoopVersionCompatibility()}-scala2.13"
Comment on lines +81 to +82
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @masseyke for finding this.

}

@Override
Expand Down
16 changes: 8 additions & 8 deletions dist/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ base {
archivesName = 'elasticsearch-hadoop'
}

def sparkVariantIncluded = 'spark30scala212'
def sparkVariantIncluded = 'spark30scala213'

configurations {
embedded {
Expand Down Expand Up @@ -86,25 +86,25 @@ dependencies {
}
implementation("org.apache.hive:hive-exec:$hiveVersion")
implementation("org.apache.hive:hive-metastore:$hiveVersion")
implementation("org.apache.spark:spark-core_${project.ext.scala212MajorVersion}:$spark30Version") {
implementation("org.apache.spark:spark-core_${project.ext.scala213MajorVersion}:$spark30Version") {
exclude group: 'javax.servlet'
exclude group: 'org.apache.hadoop'
}
implementation("org.apache.spark:spark-yarn_${project.ext.scala212MajorVersion}:$spark30Version") {
implementation("org.apache.spark:spark-yarn_${project.ext.scala213MajorVersion}:$spark30Version") {
exclude group: 'org.apache.hadoop'
}
implementation("org.apache.spark:spark-sql_${project.ext.scala212MajorVersion}:$spark30Version") {
implementation("org.apache.spark:spark-sql_${project.ext.scala213MajorVersion}:$spark30Version") {
exclude group: 'org.apache.hadoop'
}
implementation("org.apache.spark:spark-streaming_${project.ext.scala212MajorVersion}:$spark30Version") {
implementation("org.apache.spark:spark-streaming_${project.ext.scala213MajorVersion}:$spark30Version") {
exclude group: 'org.apache.hadoop'
}
implementation("org.scala-lang:scala-library:$scala211Version")
implementation("org.scala-lang:scala-reflect:$scala211Version")
implementation("org.scala-lang:scala-library:$scala213Version")
implementation("org.scala-lang:scala-reflect:$scala213Version")
implementation(project.ext.hadoopClient)
implementation("org.apache.hadoop:hadoop-common:${project.ext.hadoopVersion}")
implementation("org.apache.hadoop:hadoop-mapreduce-client-core:${project.ext.hadoopVersion}")
compileOnly("org.apache.spark:spark-catalyst_${project.ext.scala212MajorVersion}:$spark30Version")
compileOnly("org.apache.spark:spark-catalyst_${project.ext.scala213MajorVersion}:$spark30Version")
}

// Configure uber jar
Expand Down
1 change: 0 additions & 1 deletion dist/licenses/scala-library-2.11.12.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/scala-library-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3b1434403ddb147b8030f98f246153e4ce622c78
1 change: 0 additions & 1 deletion dist/licenses/scala-reflect-2.11.12.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/scala-reflect-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
46866f0e2cf6168322dc11f0f721c2db78d52ac7
1 change: 0 additions & 1 deletion dist/licenses/spark-core_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/spark-core_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a8055d61a13e9af6871e05ecdca141134d102f1f
1 change: 0 additions & 1 deletion dist/licenses/spark-sql_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/spark-sql_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
b1744080f5e2f81b9a1a088eb375d33b85132b6d
1 change: 0 additions & 1 deletion dist/licenses/spark-streaming_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/spark-streaming_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
64c4e38f3a89428926383f4d9f8a8636a81d499b
1 change: 0 additions & 1 deletion dist/licenses/spark-yarn_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions dist/licenses/spark-yarn_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
d8fd5251bb23d3bed9d9ef1f19c4402211c78fe4
1 change: 0 additions & 1 deletion licenses/scala-library-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/scala-library-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3b1434403ddb147b8030f98f246153e4ce622c78
1 change: 0 additions & 1 deletion licenses/scala-reflect-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/scala-reflect-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
46866f0e2cf6168322dc11f0f721c2db78d52ac7
1 change: 0 additions & 1 deletion licenses/spark-catalyst_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/spark-catalyst_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6a9e9c5e149bd019dd5d781888e1e81ca4d32875
1 change: 0 additions & 1 deletion licenses/spark-core_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/spark-core_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a8055d61a13e9af6871e05ecdca141134d102f1f
1 change: 0 additions & 1 deletion licenses/spark-sql_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/spark-sql_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
b1744080f5e2f81b9a1a088eb375d33b85132b6d
1 change: 0 additions & 1 deletion licenses/spark-streaming_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/spark-streaming_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
64c4e38f3a89428926383f4d9f8a8636a81d499b
1 change: 0 additions & 1 deletion licenses/spark-yarn_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions licenses/spark-yarn_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
d8fd5251bb23d3bed9d9ef1f19c4402211c78fe4
16 changes: 8 additions & 8 deletions qa/kerberos/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -63,22 +63,22 @@ configurations {
dependencies {
implementation(project(":elasticsearch-hadoop-mr"))

implementation("org.scala-lang:scala-library:${scala212Version}")
implementation("org.scala-lang:scala-reflect:${scala212Version}")
implementation("org.scala-lang:scala-library:${scala213Version}")
implementation("org.scala-lang:scala-reflect:${scala213Version}")
implementation(project(":elasticsearch-spark-30")) {
capabilities {
// Spark 3.x on Scala 2.12
requireCapability("org.elasticsearch.spark.sql.variant:spark30scala212:$project.version")
// Spark 3.x on Scala 2.13
requireCapability("org.elasticsearch.spark.sql.variant:spark30scala213:$project.version")
}
}

compileOnly("com.fasterxml.jackson.module:jackson-module-scala_2.12:2.6.7.1")
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.6.7")
compileOnly("org.json4s:json4s-jackson_2.12:3.2.11")
compileOnly("com.fasterxml.jackson.module:jackson-module-scala_${scala213MajorVersion}:2.9.10")
compileOnly("com.fasterxml.jackson.core:jackson-annotations:2.9.10")
compileOnly("org.json4s:json4s-jackson_${scala213MajorVersion}:3.6.7")
compileOnly("org.slf4j:slf4j-api:${project.ext.slf4jVersion}")

implementation("org.apache.hadoop:hadoop-client:${HadoopClusterConfiguration.HADOOP.defaultVersion()}")
implementation("org.apache.spark:spark-sql_2.12:$project.ext.spark30Version")
implementation("org.apache.spark:spark-sql_${scala213MajorVersion}:$project.ext.spark30Version")

implementation( project(path: ':elasticsearch-hadoop-mr', configuration: 'itestJarConfig'))

Expand Down
4 changes: 2 additions & 2 deletions spark/core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ sparkVariants {

// Changing the formatting of these lines could break .buildkite/pipeline.py, it uses regex to parse the `spark30scala212` part
// We should maybe move these to a separate config file that can be read from both this file and the pipeline script in the future if it creates issues
setCoreDefaultVariant "spark30scala212", spark30Version, scala212Version
addCoreFeatureVariant "spark30scala213", spark30Version, scala213Version
setCoreDefaultVariant "spark30scala213", spark30Version, scala213Version
addCoreFeatureVariant "spark30scala212", spark30Version, scala212Version

all { SparkVariantPlugin.SparkVariant variant ->

Expand Down
1 change: 0 additions & 1 deletion spark/core/licenses/scala-library-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/core/licenses/scala-library-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3b1434403ddb147b8030f98f246153e4ce622c78
1 change: 0 additions & 1 deletion spark/core/licenses/scala-reflect-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/core/licenses/scala-reflect-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
46866f0e2cf6168322dc11f0f721c2db78d52ac7
1 change: 0 additions & 1 deletion spark/core/licenses/spark-core_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/core/licenses/spark-core_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a8055d61a13e9af6871e05ecdca141134d102f1f
4 changes: 2 additions & 2 deletions spark/sql-30/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ apply plugin: 'spark.variants'

sparkVariants {
capabilityGroup 'org.elasticsearch.spark.sql.variant'
setDefaultVariant "spark30scala212", spark30Version, scala212Version
addFeatureVariant "spark30scala213", spark30Version, scala213Version
setDefaultVariant "spark30scala213", spark30Version, scala213Version
addFeatureVariant "spark30scala212", spark30Version, scala212Version

all { SparkVariantPlugin.SparkVariant variant ->
String scalaCompileTaskName = project.sourceSets
Expand Down
1 change: 0 additions & 1 deletion spark/sql-30/licenses/scala-library-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/scala-library-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
3b1434403ddb147b8030f98f246153e4ce622c78
1 change: 0 additions & 1 deletion spark/sql-30/licenses/scala-reflect-2.12.19.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/scala-reflect-2.13.13.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
46866f0e2cf6168322dc11f0f721c2db78d52ac7
1 change: 0 additions & 1 deletion spark/sql-30/licenses/spark-catalyst_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/spark-catalyst_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
6a9e9c5e149bd019dd5d781888e1e81ca4d32875
1 change: 0 additions & 1 deletion spark/sql-30/licenses/spark-core_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/spark-core_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a8055d61a13e9af6871e05ecdca141134d102f1f
1 change: 0 additions & 1 deletion spark/sql-30/licenses/spark-sql_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/spark-sql_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
b1744080f5e2f81b9a1a088eb375d33b85132b6d
1 change: 0 additions & 1 deletion spark/sql-30/licenses/spark-streaming_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/spark-streaming_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
64c4e38f3a89428926383f4d9f8a8636a81d499b
1 change: 0 additions & 1 deletion spark/sql-30/licenses/spark-yarn_2.12-3.4.3.jar.sha1

This file was deleted.

1 change: 1 addition & 0 deletions spark/sql-30/licenses/spark-yarn_2.13-3.4.3.jar.sha1
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
d8fd5251bb23d3bed9d9ef1f19c4402211c78fe4