[helpers] add support for transport options to all helpers #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lement/bulk-helper-transport-options
delvedor
reviewed
Feb 9, 2021
…lement/bulk-helper-transport-options
spalger
changed the title
delvedor
pushed a commit
that referenced
this pull request
Feb 18, 2021
Co-authored-by: spalger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to specify custom headers while using the bulk helpers, which isn't currently currently supported in this helper. This change adds support for this param, extends it to include the
,h=bppiece of thex-elastic-client-metajust like theclient.helpers.scroll(), and passes thereqOptionstoclient.bulk().Also added support for
reqOptionstoclient.helpers.msearch(). It's already supported in all other helpers