Skip to content

Path filtering improvement #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Path filtering improvement #2059

merged 2 commits into from
Nov 3, 2023

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Nov 3, 2023

Multiple lines in a single filter in paths-filter are ORed together, which means negating a list of rules filters a little too aggressively.

Switching to a single-line negative expression. The filters use picomatch so I tested the new expression against the repo with that.

@JoshMock JoshMock marked this pull request as ready for review November 3, 2023 16:41
@JoshMock JoshMock merged commit 99bcff0 into main Nov 3, 2023
@JoshMock JoshMock deleted the paths-filter-tweak branch November 3, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant