Skip to content

Make internal links plaintext in app-search-engine-exporter.ipynb #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 18, 2025

Conversation

leemthompo
Copy link
Contributor

@leemthompo leemthompo commented Mar 12, 2025

Flagged by @ppf2 in Slack: https://elastic.slack.com/archives/C07CY6V62H2/p1741637324838029

Making internal links in jump list just be plaintext because these links have weird behavior depending on where you're viewing the notebook:

  • in GitHub preview they link somewhere wrong
  • locally in VSCode they work as expected
  • in Colab they don't do anything

Flagged by @ppf2 in Slack: https://elastic.slack.com/archives/C07CY6V62H2/p1741637324838029

Making internal links in jump list just be plaintext because these links have weird behavior depending on where you're viewing the notebook: 

- :in preview they link somewhere wrong 
-   locally in VSCode they work as expected 
-  in Colab they don't do anything
@leemthompo leemthompo self-assigned this Mar 12, 2025
Copy link

gitnotebooks bot commented Mar 12, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/420

@leemthompo leemthompo requested a review from a team March 12, 2025 09:59
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@pquentin pquentin merged commit 54839a4 into main Mar 18, 2025
5 checks passed
@pquentin pquentin deleted the leemthompo-patch-1 branch March 18, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants