-
Notifications
You must be signed in to change notification settings - Fork 224
Update App Search exporter notebook #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update App Search exporter notebook #426
Conversation
Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/426 |
@@ -826,7 +838,7 @@ | |||
" \"order\": \"score\",\n", | |||
" \"encoder\": \"html\",\n", | |||
" \"require_field_match\": False,\n", | |||
" \"fields\": {},\n", | |||
" \"fields\": { \"description\" : { \"pre_tags\" : [\"<em>\"], \"post_tags\" : [\"</em>\"] } },\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous example wasn't actually returning any highlighted results
Thanks, @kderusso. Since the pre-commit checks are failing, you may want to try running the pre-commit this way:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the linting
@JessicaGarson The pre-commit hooks fail on errors unrelated to my PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good. Thanks!
Updates the App Search exporter notebook with the following:
exclude
query rules for parity withhidden
curationssemantic
queries with simplermatch
queries