Skip to content

Update App Search exporter notebook #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 18, 2025

Conversation

kderusso
Copy link
Member

Updates the App Search exporter notebook with the following:

  • Adds support for exclude query rules for parity with hidden curations
  • Uses the default ELSER endpoint, so there is no longer any need to create an inference ID
  • Replaces the example semantic queries with simpler match queries

Copy link

gitnotebooks bot commented Mar 17, 2025

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/426

@kderusso kderusso requested a review from markjhoy March 17, 2025 18:23
@@ -826,7 +838,7 @@
" \"order\": \"score\",\n",
" \"encoder\": \"html\",\n",
" \"require_field_match\": False,\n",
" \"fields\": {},\n",
" \"fields\": { \"description\" : { \"pre_tags\" : [\"<em>\"], \"post_tags\" : [\"</em>\"] } },\n",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous example wasn't actually returning any highlighted results

@JessicaGarson
Copy link
Contributor

Thanks, @kderusso. Since the pre-commit checks are failing, you may want to try running the pre-commit this way:

python -m venv .venv
.venv/bin/pip install -qqq -r requirements-dev.txt
.venv/bin/pre-commit install

Copy link
Contributor

@markjhoy markjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than the linting

@kderusso
Copy link
Member Author

@JessicaGarson The pre-commit hooks fail on errors unrelated to my PR:

 Installing ripsecrets v0.1.7 (/Users/kderusso/.cache/pre-commit/repo22ja6czc)
        Updating crates.io index
    error: failed to compile `ripsecrets v0.1.7 (/Users/kderusso/.cache/pre-commit/repo22ja6czc)`, intermediate artifacts can be found at `/Users/kderusso/.cache/pre-commit/repo22ja6czc/target`

Copy link
Contributor

@markjhoy markjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 looks good. Thanks!

@kderusso kderusso merged commit d30b609 into elastic:main Mar 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants