fix SearchResponseIterator scroll first page twice (#595) #858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, the CLA link in the PR description placeholder text is invalid(redirect to home page of elastic.co), I've already signed CLA at link(https://www.elastic.co/contributor-agreement) just 1 minutes ago. |
|
Hi @safecat thanks for this PR. Can you show me where is the wrong CA link? I'll review this PR soon. |
If someone tries to create a PR for this repo, the link is wrong in the default text in PR description text. see: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have reproduced issue #595 on es5.5 and elasticsearch-php v5.3.2.
@biopowder create the issue but never submit a PR, the PR is totally based on his code in the issue description.
Hope you can merge this into branch 5.0 and check if there is same problem for other branch, thanks.