-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Connector API #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Connector API #2531
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good, but I have questions:
- Why are we not adding tests for this new API?
- How does the spec fit in this? It seems this is an API that has been added manually. When will we be able to auto-generate this code from a common spec?
- What's up with the builds, which have lots of connection errors, report 14% coverage, and report success?
|
(cherry picked from commit dd6c015)
(cherry picked from commit dd6c015) Co-authored-by: Quentin Pradet <[email protected]>
This reverts commit dd6c015.
Each new API unfortunately requires manual steps.