-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove unneded nonlocal and global declarations #2866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miguelgrinberg
merged 1 commit into
elastic:main
from
miguelgrinberg:linter-nonlocal-updates
Mar 31, 2025
Merged
Remove unneded nonlocal and global declarations #2866
miguelgrinberg
merged 1 commit into
elastic:main
from
miguelgrinberg:linter-nonlocal-updates
Mar 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
approved these changes
Mar 31, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 83025a6)
github-actions bot
pushed a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 83025a6)
This was referenced Mar 31, 2025
miguelgrinberg
added a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 83025a6) Co-authored-by: Miguel Grinberg <[email protected]>
miguelgrinberg
added a commit
that referenced
this pull request
Mar 31, 2025
(cherry picked from commit 83025a6) Co-authored-by: Miguel Grinberg <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 1, 2025
(cherry picked from commit 83025a6)
pquentin
pushed a commit
that referenced
this pull request
Apr 1, 2025
(cherry picked from commit 83025a6) Co-authored-by: Miguel Grinberg <[email protected]>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 29, 2025
(cherry picked from commit 83025a6)
pquentin
pushed a commit
that referenced
this pull request
Apr 29, 2025
(cherry picked from commit 83025a6) Co-authored-by: Miguel Grinberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new release of flake8 reports a few unnecessary
nonlocal
andglobal
declarations.