Skip to content

Remove parent/child tests #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2024
Merged

Remove parent/child tests #45

merged 1 commit into from
May 30, 2024

Conversation

pquentin
Copy link
Member

Using a join type requires the routing field which is apparently forbidden in serverless.

ERROR test_elasticsearch_serverless/test_server/test_helpers.py::test_children_are_reindexed_correctly - elasticsearch_serverless.exceptions.BadRequestError: BadRequestError(400, 'status_exception', 'Parameter validation failed for [/test-index/_doc/47]: The http parameter [routing] (with value [42]) is not permitted when running in serverless mode')

(Using this feature isn't really recommended anyway.)

@pquentin
Remove parent/child tests
cc6b04e 
Using a join type requires the routing field which is forbidden in
serverless. Using this feature isn't really recommended anyway.

https://www.elastic.co/guide/en/elasticsearch/reference/current/parent-join.html
@pquentin pquentin requested a review from miguelgrinberg May 30, 2024 10:15
@pquentin pquentin merged commit aba9787 into elastic:main May 30, 2024
9 of 10 checks passed
@pquentin pquentin deleted the parent-join branch May 30, 2024 16:33
@pquentin pquentin mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miguelgrinberg miguelgrinberg miguelgrinberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pquentin @miguelgrinberg