Skip to content

Extract SearchTemplateRequestBody in watcher #1564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 23, 2022

Conversation

Anaethelion
Copy link
Contributor

Use the duplicate in watcher instead of referencing the request directly.

Copy link
Member

@delvedor delvedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Can you run make contrib and push again?

@Anaethelion Anaethelion force-pushed the extract_search_template_body branch from d21b5b9 to 65d538b Compare March 23, 2022 09:38
@Anaethelion
Copy link
Contributor Author

LGTM

Can you run make contrib and push again?

Done!

@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@Anaethelion Anaethelion merged commit f734065 into main Mar 23, 2022
@Anaethelion Anaethelion deleted the extract_search_template_body branch March 23, 2022 09:59
@delvedor
Copy link
Member

Adding the breaking label. This pr fixes the definition, but it will "break" the generated types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants