Skip to content

Removed redundant date types #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Removed redundant date types #1673

wants to merge 3 commits into from

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented May 3, 2022

As titled.

We will verify if we have used the wrong date type in the various properties in a separate PR.

@delvedor delvedor requested a review from a team May 3, 2022 15:15
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

Following you can find the validation results for the APIs you have changed.

API Status Request Response
async_search.delete 🟢 3/3 3/3
async_search.get 🟢 4/4 4/4
async_search.status 🟢 3/3 3/3
async_search.submit 🟢 6/6 6/6
cat.count 🟢 9/9 9/9
cat.health 🟢 5/5 5/5
cat.snapshots 🟢 4/4 4/4
ccr.delete_auto_follow_pattern Missing test Missing test
ccr.follow_info Missing test Missing test
ccr.follow_stats Missing test Missing test
ccr.follow Missing test Missing test
ccr.forget_follower Missing test Missing test
ccr.get_auto_follow_pattern Missing test Missing test
ccr.pause_auto_follow_pattern Missing test Missing test
ccr.pause_follow Missing test Missing test
ccr.put_auto_follow_pattern Missing test Missing test
ccr.resume_auto_follow_pattern Missing test Missing test
ccr.resume_follow Missing test Missing test
ccr.stats Missing test Missing test
ccr.unfollow Missing test Missing test
cluster.health 🟢 137/137 137/137
dangling_indices.list_dangling_indices Missing test Missing test
eql.get_status 🟢 3/3 3/3
ilm.explain_lifecycle 🟢 5/5 5/5
indices.field_usage_stats 🟢 5/5 5/5
indices.recovery 🟢 11/11 11/11
indices.rollover 🟢 14/14 14/14
license.delete 🟢 3/3 3/3
license.get_basic_status 🟢 3/3 3/3
license.get_trial_status 🟢 3/3 3/3
license.get 🟢 5/5 5/5
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🔴 0/1 1/1
logstash.delete_pipeline Missing test Missing test
logstash.get_pipeline Missing test Missing test
logstash.put_pipeline Missing test Missing test
ml.close_job 🟢 62/62 61/61
ml.delete_calendar_event 🟢 4/4 4/4
ml.delete_calendar_job 🟢 3/3 3/3
ml.delete_calendar 🟢 5/5 5/5
ml.delete_data_frame_analytics 🟢 2/2 2/2
ml.delete_datafeed 🟢 3/3 3/3
ml.delete_expired_data 🟢 5/5 5/5
ml.delete_filter 🟢 27/27 27/27
ml.delete_forecast 🟢 3/3 3/3
ml.delete_job 🟢 47/47 47/47
ml.delete_model_snapshot 🟢 2/2 2/2
ml.delete_trained_model_alias 🟢 3/3 3/3
ml.delete_trained_model 🟢 3/3 3/3
ml.estimate_model_memory 🟢 16/16 16/16
ml.evaluate_data_frame 🟢 22/22 22/22
ml.explain_data_frame_analytics 🟢 7/7 7/7
ml.flush_job 🟢 15/15 15/15
ml.forecast 🟢 1/1 1/1
ml.get_buckets 🟢 14/14 14/14
ml.get_calendar_events 🟢 17/17 17/17
ml.get_calendars 🟢 17/17 17/17
ml.get_categories 🟢 12/12 12/12
ml.get_data_frame_analytics_stats 🟢 12/12 12/12
ml.get_data_frame_analytics 🟢 17/17 17/17
ml.get_datafeed_stats 🟢 27/27 27/27
ml.get_datafeeds 🟢 20/20 20/20
ml.get_filters 🟢 13/13 13/13
ml.get_influencers 🟢 11/11 11/11
ml.get_job_stats 🟢 31/31 31/31
ml.get_jobs 🟢 31/31 31/31
ml.get_memory_stats Missing test Missing test
ml.get_model_snapshot_upgrade_stats 🟠 Missing recording Missing recording
ml.get_model_snapshots 🟢 18/18 18/18
ml.get_overall_buckets 🟢 16/16 15/15
ml.get_records 🟢 8/8 8/8
ml.get_trained_models_stats 🟢 12/12 12/12
ml.get_trained_models 🔴 21/27 25/27
ml.infer_trained_model_deployment Missing test Missing test
ml.info 🟢 10/10 10/10
ml.open_job 🔴 83/83 9/83
ml.post_calendar_events 🟢 21/21 21/21
ml.post_data 🔴 8/10 13/17
ml.preview_data_frame_analytics 🟢 3/3 3/3
ml.preview_datafeed 🔴 10/16 8/16
ml.put_calendar_job 🔴 11/12 12/12
ml.put_calendar 🟢 135/135 135/135
ml.put_data_frame_analytics 🟢 33/33 33/33
ml.put_datafeed 🔴 70/71 12/71
ml.put_filter 🟢 27/27 27/27
ml.put_job 🔴 0/226 1/224
ml.put_trained_model_alias 🟢 9/9 9/9
ml.put_trained_model_definition_part Missing test Missing test
ml.put_trained_model_vocabulary Missing test Missing test
ml.put_trained_model 🔴 3/5 3/5
ml.reset_job 🟢 2/2 2/2
ml.revert_model_snapshot 🟢 2/2 2/2
ml.set_upgrade_mode 🟢 6/6 6/6
ml.start_data_frame_analytics 🟢 1/1 1/1
ml.start_datafeed 🟢 24/24 24/24
ml.start_trained_model_deployment Missing test Missing test
ml.stop_data_frame_analytics 🟢 5/5 5/5
ml.stop_datafeed 🟢 17/17 17/17
ml.stop_trained_model_deployment Missing test Missing test
ml.update_data_frame_analytics 🟢 2/2 2/2
ml.update_datafeed 🔴 6/7 6/7
ml.update_filter 🟢 3/3 3/3
ml.update_job 🔴 3/5 5/5
ml.update_model_snapshot 🟢 3/3 3/3
ml.upgrade_job_snapshot 🟢 3/3 3/3
ml.validate_detector 🟢 2/2 2/2
ml.validate 🟢 3/3 3/3
nodes.clear_repositories_metering_archive Missing test Missing test
nodes.get_repositories_metering_info Missing test Missing test
nodes.hot_threads 🔴 5/5 0/5
nodes.info 🟢 84/84 84/84
nodes.reload_secure_settings 🟢 2/2 2/2
nodes.stats 🟢 42/42 42/42
nodes.usage 🟢 1/1 1/1
reindex 🟢 15/15 14/14
security.grant_api_key 🟢 12/12 12/12
shutdown.get_node Missing test Missing test
slm.delete_lifecycle 🟢 4/4 4/4
slm.execute_lifecycle 🟢 4/4 4/4
slm.execute_retention 🟢 4/4 4/4
slm.get_lifecycle 🟢 16/16 16/16
slm.get_stats 🟢 4/4 4/4
slm.get_status 🟢 4/4 4/4
slm.put_lifecycle 🟢 4/4 4/4
slm.start Missing test Missing test
slm.stop 🟢 4/4 4/4
snapshot.cleanup_repository 🟢 3/3 3/3
snapshot.clone 🟢 5/5 5/5
snapshot.create_repository 🟢 26/26 26/26
snapshot.create 🟢 25/25 25/25
snapshot.delete_repository 🟢 10/10 10/10
snapshot.delete 🟢 19/19 19/19
snapshot.get_repository 🟢 19/19 19/19
snapshot.get 🟢 12/12 12/12
snapshot.repository_analyze 🟠 Missing type Missing type
snapshot.restore 🟢 5/5 5/5
snapshot.status 🟢 2/2 2/2
snapshot.verify_repository 🟢 2/2 2/2
sql.get_async_status Missing test Missing test
transform.get_transform_stats 🟢 31/31 31/31
transform.get_transform 🟢 26/26 26/26
watcher.ack_watch 🟢 1/1 1/1
watcher.activate_watch 🟢 1/1 1/1
watcher.deactivate_watch 🟢 1/1 1/1
watcher.delete_watch 🟢 2/2 2/2
watcher.execute_watch 🟢 7/7 7/7
watcher.get_watch 🟢 9/9 9/9
watcher.put_watch 🔴 29/38 38/38
watcher.query_watches Missing test Missing test
watcher.start 🟢 1/1 1/1
watcher.stats 🟢 1/1 1/1
watcher.stop 🟢 1/1 1/1
xpack.info 🔴 8/8 1/4

You can validate these APIs yourself by using the make validate target.

@elastic elastic deleted a comment from github-actions bot May 3, 2022
@swallez swallez self-requested a review May 10, 2022 13:03
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time represents durations (see the number of timeout, offset and interval fields where it's used) and so cannot replace EpochMillis. That being said, there are also occurrences of Time that seem wrong, e.g. BucketSummary.timestamp.

@swallez
Copy link
Member

swallez commented May 17, 2022

Superseded by #1713

@swallez swallez closed this May 17, 2022
@delvedor delvedor deleted the dates-first-round branch May 18, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants