-
Notifications
You must be signed in to change notification settings - Fork 101
Add the "es_quirk" annotation to capture snowflakes in ES behavior #1674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a note about this new tag in both docs/known-issues.md
and docs/modeling-guide.md
?
Added some docs. |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1674-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 6b87085253f821375e300dd82bac6fdcf8e2cc78
# Push it to GitHub
git push --set-upstream origin backport-1674-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
Adds a new
@es_quirk
jsdoc tag to capture weird snowflakes in the specification. This tag's value is a description of the quirk.It is exported in
schema.json
as anesQuirk?: string
property on type definition and properties. This allows code generators to track the quirks they have effectively implemented and fail if a new quirk appears in the schema that needs to be handled in the code generator.