Skip to content

[Backport 7.17] Remove Name from PropertyBase #1712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 17, 2022
Merged

[Backport 7.17] Remove Name from PropertyBase #1712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
182b477
Remove name from PropertyBase (#1710)
stevejgordon May 17, 2022
61584bd
Re-run make contrib
stevejgordon May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 9 additions & 20 deletions output/schema/schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion output/typescript/types.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion specification/_types/mapping/Property.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import {
export class PropertyBase {
local_metadata?: Metadata
meta?: Dictionary<string, string>
name?: PropertyName
properties?: Dictionary<PropertyName, Property>
ignore_above?: integer
dynamic?: DynamicMapping
Expand Down
6 changes: 6 additions & 0 deletions specification/_types/mapping/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,12 @@ export class SearchAsYouTypeProperty extends CorePropertyBase {
type: 'search_as_you_type'
}

// MatchOnlyTextProperty is an example of a property which does not derive from PropertyBase.
// We have checked and this property does not support all properties of the base type.
// In a future iteration we may remodel properties and identify truely common properties that should form
// a base type that can be considered a common ancestor for all properties. Some clients will generate
// a synthetic version of this today.

/**
* A variant of text that trades scoring and efficiency of positional queries for space efficiency. This field
* effectively stores data the same way as a text field that only indexes documents (index_options: docs) and
Expand Down