Skip to content

Add missing params to shutdown APIs #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2022
Merged

Add missing params to shutdown APIs #1718

merged 2 commits into from
May 20, 2022

Conversation

delvedor
Copy link
Member

As titled.

Related: elastic/elasticsearch-js#1695

@delvedor delvedor requested a review from a team May 20, 2022 10:30
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
shutdown.delete_node Missing test Missing test
shutdown.get_node Missing test Missing test
shutdown.put_node Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delvedor delvedor merged commit e824309 into main May 20, 2022
@delvedor delvedor deleted the fix-shutdown-api branch May 20, 2022 11:59
github-actions bot pushed a commit that referenced this pull request May 20, 2022
* Update shutdown APIs

* Updated output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants