Skip to content

Fix issues in indices API - java-client+recordings #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 5, 2022
Merged

Conversation

Anaethelion
Copy link
Contributor

Addresses most of #1881

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.add_block 🟢 2/2 2/2
indices.analyze 🟢 20/20 20/20
indices.clear_cache 🟢 4/4 4/4
indices.clone 🟢 6/6 6/6
indices.close 🟢 43/43 43/43
indices.create_data_stream 🟢 25/25 25/25
indices.create 🔴 734/737 737/737
indices.data_streams_stats 🟢 4/4 4/4
indices.delete_alias 🟢 15/15 15/15
indices.delete_data_stream 🟢 27/27 27/27
indices.delete_index_template 🟢 1/1 1/1
indices.delete_template 🟢 9/9 9/9
indices.delete 🟢 104/104 104/104
indices.disk_usage 🟢 5/5 5/5
indices.downsample Missing test Missing test
indices.exists_alias 🟢 36/36 36/36
indices.exists_index_template Missing test Missing test
indices.exists_template 🟢 15/15 15/15
indices.exists 🟢 39/39 39/39
indices.field_usage_stats 🟢 5/5 5/5
indices.flush 🟢 9/9 9/9
indices.forcemerge 🔴 4/4 3/4
indices.get_alias 🔴 82/82 70/82
indices.get_data_stream 🟢 12/12 12/12
indices.get_field_mapping 🔴 15/15 14/15
indices.get_index_template 🔴 16/16 14/16
indices.get_mapping 🟢 60/60 60/60
indices.get_settings 🔴 54/54 47/54
indices.get_template 🟢 30/30 30/30
indices.get 🟢 52/52 52/52
indices.migrate_to_data_stream Missing test Missing test
indices.modify_data_stream Missing test Missing test
indices.open 🟢 17/17 17/17
indices.promote_data_stream Missing test Missing test
indices.put_alias 🟢 55/55 55/55
indices.put_index_template 🔴 37/38 38/38
indices.put_mapping 🔴 73/74 74/74
indices.put_settings 🔴 52/55 55/55
indices.put_template 🔴 40/46 46/46
indices.recovery 🟢 11/11 11/11
indices.refresh 🟢 199/199 199/199
indices.reload_search_analyzers 🟢 2/2 2/2
indices.resolve_index 🟢 6/6 6/6
indices.rollover 🔴 22/26 26/26
indices.segments 🔴 6/6 4/6
indices.shard_stores 🔴 5/5 2/5
indices.shrink 🟢 5/5 5/5
indices.simulate_index_template 🟢 6/6 6/6
indices.simulate_template 🟢 4/4 4/4
indices.split 🟢 11/11 11/11
indices.stats 🟢 83/83 82/82
indices.unfreeze 🟢 1/1 1/1
indices.update_aliases 🟢 22/22 22/22
indices.validate_query 🟢 7/7 7/7

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anaethelion Anaethelion merged commit 9ea7323 into main Oct 5, 2022
@Anaethelion Anaethelion deleted the lsf/fix/indices branch October 5, 2022 14:35
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
* Extract forcemerge.response, add task optional property

* Add eager_global_ordinals to JoinProperty

* Add created_string to IndexVersioning, Change SimilarityBm25 b property to double to reflect float from server

* Extract forcemerge response, add optional task

* Add missing properties to RolloverConditions

* Update schema
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1941-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 9ea732335c231fdb5a1558220d5948f4552a897f
# Push it to GitHub
git push --set-upstream origin backport-1941-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1941-to-7.17.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

The backport to 8.5 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.5 8.5
# Navigate to the new working tree
cd .worktrees/backport-8.5
# Create a new branch
git switch --create backport-1941-to-8.5
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 9ea732335c231fdb5a1558220d5948f4552a897f
# Push it to GitHub
git push --set-upstream origin backport-1941-to-8.5
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.5

Then, create a pull request where the base branch is 8.5 and the compare/head branch is backport-1941-to-8.5.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2022

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1941-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 9ea732335c231fdb5a1558220d5948f4552a897f
# Push it to GitHub
git push --set-upstream origin backport-1941-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1941-to-7.17.

Anaethelion added a commit that referenced this pull request Oct 5, 2022
* Extract forcemerge.response, add task optional property

* Add eager_global_ordinals to JoinProperty

* Add created_string to IndexVersioning, Change SimilarityBm25 b property to double to reflect float from server

* Extract forcemerge response, add optional task

* Add missing properties to RolloverConditions

* Update schema

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants