Skip to content

Fix misc issues found with java-client+recordings #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

swallez
Copy link
Member

@swallez swallez commented Oct 5, 2022

Fixes #1887

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, few thoughts:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

Following you can find the validation results for the APIs you have changed.

API Status Request Response
enrich.delete_policy 🟢 5/5 5/5
enrich.execute_policy 🟢 6/6 6/6
enrich.get_policy 🟢 6/6 6/6
enrich.put_policy 🟢 6/6 6/6
enrich.stats 🟢 5/5 5/5
ingest.simulate 🟢 4/4 4/4
license.post 🟢 1/1 1/1
ssl.certificates 🟢 2/2 2/2
transform.delete_transform 🟢 9/9 9/9
transform.get_transform_stats 🟢 31/31 31/31
transform.get_transform 🟢 26/26 26/26
transform.preview_transform 🟢 17/17 17/17
transform.put_transform 🟢 26/26 26/26
transform.reset_transform 🟢 4/4 4/4
transform.start_transform 🟢 26/26 26/26
transform.stop_transform 🟢 15/15 15/15
transform.update_transform 🟢 13/13 13/13
transform.upgrade_transforms 🟢 2/2 2/2
xpack.usage 🔴 19/19 0/15

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swallez swallez merged commit b0f41a5 into main Oct 6, 2022
@swallez swallez deleted the fix-misc-java-recordings branch October 6, 2022 16:04
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2022

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1945-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 b0f41a5f37ace44ee7476838f433b3128caef79e
# Push it to GitHub
git push --set-upstream origin backport-1945-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-1945-to-7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java-client+recordings validation errors - Misc
2 participants