Skip to content

Fix descriptions of only_managed and only_errors #1973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Fix descriptions of only_managed and only_errors #1973

merged 1 commit into from
Oct 26, 2022

Conversation

miriam-eid
Copy link
Contributor

Fixes #1876

@miriam-eid miriam-eid requested a review from ezimuel October 24, 2022 13:15
@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
ilm.explain_lifecycle 🟢 5/5 5/5

You can validate this API yourself by using the make validate target.

@technige
Copy link
Contributor

LGTM 👍

@technige technige requested review from technige and removed request for ezimuel October 26, 2022 08:38
technige
technige approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@technige technige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@miriam-eid miriam-eid merged commit d907ed9 into main Oct 26, 2022
@miriam-eid miriam-eid deleted the swap-descriptions branch October 26, 2022 08:39
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Merged
github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
@miriam-eid @github-actions
Fix descriptions of only_managed and only_errors (#1973)
a97846e
github-actions bot pushed a commit that referenced this pull request Oct 27, 2022
@miriam-eid @github-actions
Fix descriptions of only_managed and only_errors (#1973)
375fed3
@github-actions github-actions bot mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technige technige technige approved these changes

Assignees
No one assigned
Labels
backport 7.17 backport 8.5 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Descriptions of only_managed and only_errors have been swapped
3 participants
@miriam-eid @technige @miriameid