-
Notifications
You must be signed in to change notification settings - Fork 102
Remove local-metadata from PropertyBase #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.0 8.0
# Navigate to the new working tree
cd .worktrees/backport-8.0
# Create a new branch
git switch --create backport-1979-to-8.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-8.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.0 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-1979-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.1 8.1
# Navigate to the new working tree
cd .worktrees/backport-8.1
# Create a new branch
git switch --create backport-1979-to-8.1
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-8.1
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.1 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.2 8.2
# Navigate to the new working tree
cd .worktrees/backport-8.2
# Create a new branch
git switch --create backport-1979-to-8.2
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-8.2
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.2 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.3 8.3
# Navigate to the new working tree
cd .worktrees/backport-8.3
# Create a new branch
git switch --create backport-1979-to-8.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-8.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.3 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.4 8.4
# Navigate to the new working tree
cd .worktrees/backport-8.4
# Create a new branch
git switch --create backport-1979-to-8.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 0f1a36891730a8a3c68bf88947d590107637fdd8
# Push it to GitHub
git push --set-upstream origin backport-1979-to-8.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.4 Then, create a pull request where the |
Co-authored-by: Steve Gordon <[email protected]>
(cherry picked from commit 0f1a368)
local-metadata
is a NEST client concept and not part of the server model. NEST added it to support consumers who wanted to tag properties with extra data. It is not serialized on requests and I can find no reference for it in Elasticsearch. This PR removes it and I propose we backport it to all versions.