Skip to content

Improve route serialization #1996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 8, 2022
Merged

Improve route serialization #1996

merged 4 commits into from
Dec 8, 2022

Conversation

Anaethelion
Copy link
Contributor

Follow up to #1992

This changes:

  • Uses string for version in serialization.
  • Unexports the field of the Go structures in serialization.
  • Add the generated code disclaimer.

@cla-checker-service
Copy link

cla-checker-service bot commented Dec 8, 2022 •
edited
Loading

💚 CLA has been signed

sethmlarson
sethmlarson approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm

@Anaethelion Anaethelion force-pushed the improve_route_serialization branch from 4c66908 to 9b54e5f Compare December 8, 2022 16:26
@Anaethelion Anaethelion merged commit 66fc1fd into main Dec 8, 2022
@Anaethelion Anaethelion deleted the improve_route_serialization branch December 8, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees
No one assigned
Labels
compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Anaethelion @sethmlarson