Skip to content

[KNN] Add query vector builder #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2023
Merged

[KNN] Add query vector builder #2028

merged 6 commits into from
Mar 8, 2023

Conversation

Anaethelion
Copy link
Contributor

This adds the query_vector_builder field to the KnnQuery for semantic search.
https://www.elastic.co/guide/en/elasticsearch/reference/master/knn-search.html#semantic-search

@Anaethelion Anaethelion changed the title Add query vector builder [KNN] Add query vector builder Mar 8, 2023
@Anaethelion Anaethelion requested a review from swallez March 8, 2023 10:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
knn_search 🟢 4/4 4/4

You can validate these APIs yourself by using the make validate target.

@Anaethelion Anaethelion merged commit 50643d0 into main Mar 8, 2023
@Anaethelion Anaethelion deleted the add_query_vector_builder branch March 8, 2023 10:29
github-actions bot pushed a commit that referenced this pull request Mar 8, 2023
* Add query_vector_builder to the knn search object

* Add contrib update

* Move QueryVector type to knn types, change its type to float

* Make QueryVectorBuilder a container to reflect its nature server-side

* make contrib

* Add deprecation notice for knn_search.Request
Anaethelion added a commit that referenced this pull request Mar 8, 2023
* Add query_vector_builder to the knn search object

* Add contrib update

* Move QueryVector type to knn types, change its type to float

* Make QueryVectorBuilder a container to reflect its nature server-side

* make contrib

* Add deprecation notice for knn_search.Request

Co-authored-by: Laurent Saint-Félix <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants