Fix completion suggester #2044
Merged
Fix completion suggester #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anaethelion
reviewed
Mar 23, 2023
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Fix completion suggester * Fix flags which is a union
github-actions bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Fix completion suggester * Fix flags which is a union
stevejgordon
added a commit
that referenced
this pull request
Mar 23, 2023
* Fix completion suggester * Fix flags which is a union Co-authored-by: Steve Gordon <[email protected]>
stevejgordon
added a commit
that referenced
this pull request
Mar 23, 2023
* Fix completion suggester * Fix flags which is a union Co-authored-by: Steve Gordon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues raised in elastic/elasticsearch-net#7454.
The completion suggester doesn't support a field named "prefix" which is a FieldSuggester container property.
After reviewing the server code, I noticed that
regexis not a string but an instance ofRegexOptionsused to control the regex provided via the container property.