Skip to content

Add from parameter for transform.start_transform #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Apr 6, 2023

This PR adds the from parameter for transform.start_transform API. Fixes #2064

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Following you can find the validation results for the API you have changed.

API Status Request Response
transform.start_transform 🟢 27/27 27/27

You can validate this API yourself by using the make validate target.

Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@ezimuel ezimuel merged commit 850e556 into main Apr 6, 2023
@ezimuel ezimuel deleted the add/from-param branch April 6, 2023 13:05
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

The backport to 8.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.7 8.7
# Navigate to the new working tree
cd .worktrees/backport-8.7
# Create a new branch
git switch --create backport-2065-to-8.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 850e5568a84743b0157c81b3f6f493a7eeddbf54
# Push it to GitHub
git push --set-upstream origin backport-2065-to-8.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.7

Then, create a pull request where the base branch is 8.7 and the compare/head branch is backport-2065-to-8.7.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

The backport to 8.7 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.7 8.7
# Navigate to the new working tree
cd .worktrees/backport-8.7
# Create a new branch
git switch --create backport-2065-to-8.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 850e5568a84743b0157c81b3f6f493a7eeddbf54
# Push it to GitHub
git push --set-upstream origin backport-2065-to-8.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.7

Then, create a pull request where the base branch is 8.7 and the compare/head branch is backport-2065-to-8.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add from query parameter to transform.start_transform API
2 participants