Skip to content

ML Add trained model definition status to TrainedModelConfig #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

davidkyle
Copy link
Member

Updates TrainedModelConfig for the new fully_defined field add in elastic/elasticsearch#95271

@davidkyle davidkyle requested a review from lcawl April 24, 2023 11:50
@davidkyle
Copy link
Member Author

davidkyle commented Apr 24, 2023

The Validate APIs / build (pull_request) action is failing with Input required and not supplied: token

I do not know how to fix that, can someone help please.

EDIT
could the error be caused by a missing secrets.PAT?

https://github.com/elastic/elasticsearch-specification/blob/main/.github/workflows/validate-pr.yml#L32

@swallez
Copy link
Member

swallez commented Apr 24, 2023

@davidkyle indeed this is because of secrets.PAT which isn't exposed in PRs from a fork. This access token allows to check out the private flight-recorder repository to build a validation report for the changes. Now looking at it further, we actually don't really need this private token since all Elastic employees have read access to that private repo and their token will have enough karma.

I'll open a PR to fix this, and in the meantime we can ignore this failed check. We will merge the PR once @lcawl has reviewed it.

@davidkyle
Copy link
Member Author

Thanks @swallez

I've opened another PR with the same change but against this repo rather than a fork. Lets see if #2093 passes

@davidkyle
Copy link
Member Author

Lets see if #2093 passes

Yes it did. Strangely this PR has now started passing too!.

Closing anyway in preference to #2093

@davidkyle davidkyle closed this Apr 24, 2023
@davidkyle davidkyle deleted the model-def-status branch April 24, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants