-
Notifications
You must be signed in to change notification settings - Fork 102
Stringify relevant properties #2085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 CLA has been signed |
1089381
to
fbd3860
Compare
fbd3860
to
7fe9f68
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
swallez
approved these changes
Apr 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
* Stringify relevant properties * Add missing stringified in metadata for IndexSettingBlocks
Anaethelion
added a commit
that referenced
this pull request
Apr 20, 2023
* Stringify relevant properties * Add missing stringified in metadata for IndexSettingBlocks Co-authored-by: Laurent Saint-Félix <[email protected]>
swallez
pushed a commit
that referenced
this pull request
Jul 5, 2023
* Stringify relevant properties * Add missing stringified in metadata for IndexSettingBlocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While hardening the JSON decode tests for the Go client I've stumbled upon several instance of integer and one boolean that can also be a string in some instances.