Skip to content

Move generic array to root of response body #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

Anaethelion
Copy link
Contributor

Following tests and documentation, ml.preview_data_feed should have the array of generics at the root of its response.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
ml.preview_datafeed 🔴 10/17 17/17

You can validate this API yourself by using the make validate target.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anaethelion Anaethelion merged commit 8e3ed49 into main Apr 21, 2023
@Anaethelion Anaethelion deleted the fix_mlpreviewdatafeed branch April 21, 2023 14:21
Anaethelion added a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants