Skip to content

Add 408 as exception status code for normal behaviour on cluster_health #2089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

Anaethelion
Copy link
Contributor

cluster_health could return a valid payload with a 408 status code if one of the nodes from the cluster failed to respond before the timeout.

@github-actions
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
cluster.health 🟢 146/146 146/146

You can validate this API yourself by using the make validate target.

Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Anaethelion Anaethelion merged commit fb9aa45 into main Apr 21, 2023
@Anaethelion Anaethelion deleted the fix_cluster_health_exception branch April 21, 2023 14:28
github-actions bot pushed a commit that referenced this pull request Apr 21, 2023
…th (#2089)

* Add 408 as exception status code for normal behaviour on cluster_health

* Rename body response type to HealthResponseBody
Anaethelion added a commit that referenced this pull request Apr 21, 2023
…th (#2089) (#2091)

* Add 408 as exception status code for normal behaviour on cluster_health

* Rename body response type to HealthResponseBody

Co-authored-by: Laurent Saint-Félix <[email protected]>
swallez pushed a commit that referenced this pull request Jul 5, 2023
…th (#2089)

* Add 408 as exception status code for normal behaviour on cluster_health

* Rename body response type to HealthResponseBody
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants