Skip to content

Correcting visibility of ML APIs in serverless #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

droberts195
Copy link
Contributor

Two ML APIs had the wrong serverless visibility:

  1. Post data should not be visible at all in serverless
  2. Infer trained model should be visible publicly

(With the infer endpoint there was confusion about the deprecated infer trained model deployment API, which we want to pretend does not exist.)

Two ML APIs had the wrong serverless visibility:

1. Post data should not be visible at all in serverless
2. Infer trained model should be visible publicly

(With the infer endpoint there was confusion about the
deprecated infer trained model _deployment_ API, which
we want to pretend does not exist.)
@droberts195 droberts195 requested review from a team as code owners July 24, 2023 17:44
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.infer_trained_model Missing test Missing test
ml.post_data 🔴 8/10 13/17

You can validate these APIs yourself by using the make validate target.

@droberts195 droberts195 merged commit 8fb16d8 into main Jul 24, 2023
@droberts195 droberts195 deleted the correct_ml_api_vis branch July 24, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants