Skip to content

Add Query Rules API #2207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 27, 2023
Merged

Add Query Rules API #2207

merged 10 commits into from
Jul 27, 2023

Conversation

kderusso
Copy link
Member

Adds the query rules CRUD API and the new Rule Query query DSL

@kderusso kderusso marked this pull request as ready for review July 25, 2023 14:14
@kderusso kderusso requested a review from a team as a code owner July 25, 2023 14:14
@kderusso kderusso requested a review from carlosdelest July 25, 2023 14:16
carlosdelest
carlosdelest reviewed Jul 25, 2023
View reviewed changes
@kderusso kderusso requested a review from carlosdelest July 26, 2023 12:16
carlosdelest
carlosdelest approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🚀

@kderusso kderusso mentioned this pull request Jul 26, 2023
Merged
Anaethelion
Anaethelion requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question and a nit to align with existing spec.
Otherwise LGTM

@kderusso kderusso force-pushed the kderusso/add-query-rules-apis-to-clients branch from bdb359f to 366ff23 Compare July 27, 2023 14:27
@kderusso kderusso requested a review from Anaethelion July 27, 2023 14:28
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
query_ruleset.delete ⚪ Missing test Missing test
query_ruleset.get ⚪ Missing test Missing test
query_ruleset.list ⚪ Missing test Missing test
query_ruleset.put ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Anaethelion
Anaethelion approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kderusso kderusso merged commit fa566ed into main Jul 27, 2023
@kderusso kderusso deleted the kderusso/add-query-rules-apis-to-clients branch July 27, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anaethelion Anaethelion Anaethelion approved these changes

@carlosdelest carlosdelest carlosdelest approved these changes

Assignees
No one assigned
Labels
enhancement specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kderusso @Anaethelion @carlosdelest