Search Response has completion_time and _cluster/details #2260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swallez
requested changes
Aug 31, 2023
specification/_types/Stats.ts
Outdated
| export class ClusterDetails { | ||
| status: ClusterSearchStatusEnum | ||
| indices: string | ||
| took?: long |
There was a problem hiding this comment.
What is the unit of this value? If it's millis, this should be DurationValue<UnitMillis> (both defined in _types/Time.ts
There was a problem hiding this comment.
Yes, a millis timestamp. I'll change it, thanks!
There was a problem hiding this comment.
Oh, I copied the value from the took entry in SearchResponse:
This is the "same" took value (just in a different subsection), so should I have them consistent?
If yes, should I change the above one to DurationValue<UnitMillis> also?
There was a problem hiding this comment.
Actually that usage is in a bunch of places. Not sure I want to update all those (?)
./specification/fleet/search/SearchResponse.ts: took: long
./specification/rollup/rollup_search/RollupSearchResponse.ts: took: long
./specification/_global/search/SearchResponse.ts: took: long
./specification/_global/knn_search/KnnSearchResponse.ts: took: long
Updates the spec for the response objects for `POST _async_search`, `GET _async_search/:id`, `GET _async_search/status/:id` and `GET _search` Two high level changes have happened in 8.10: 1) `completion_time` and `completion_time_in_millis` (async_search only) elastic/elasticsearch#97700 2) Adding `details` metadata to the `_clusters` section of both async and synchronous search responses elastic/elasticsearch#97731
quux00
force-pushed
the
search/response-updates
branch
from
5dbf924 to
a37c526
Compare
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.10 8.10
# Navigate to the new working tree
cd .worktrees/backport-8.10
# Create a new branch
git switch --create backport-2260-to-8.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 676cf674188b2ff65f762fc9c79180ce9f97b7bf
# Push it to GitHub
git push --set-upstream origin backport-2260-to-8.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.10Then, create a pull request where the |
swallez
pushed a commit
that referenced
this pull request
Sep 1, 2023
Updates the spec for the response objects for `POST _async_search`, `GET _async_search/:id`, `GET _async_search/status/:id` and `GET _search` Two high level changes have happened in 8.10: 1) `completion_time` and `completion_time_in_millis` (async_search only) elastic/elasticsearch#97700 2) Adding `details` metadata to the `_clusters` section of both async and synchronous search responses elastic/elasticsearch#97731
swallez
added a commit
that referenced
this pull request
Sep 5, 2023
Updates the spec for the response objects for `POST _async_search`, `GET _async_search/:id`, `GET _async_search/status/:id` and `GET _search` Two high level changes have happened in 8.10: 1) `completion_time` and `completion_time_in_millis` (async_search only) elastic/elasticsearch#97700 2) Adding `details` metadata to the `_clusters` section of both async and synchronous search responses elastic/elasticsearch#97731 Co-authored-by: Michael Peterson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the spec for the response objects for
POST _async_search,GET _async_search/:id,GET _async_search/status/:idandGET _searchTwo high level changes have happened in 8.10:
completion_timeandcompletion_time_in_millis(async_search only) Add completion_time time field to async_search get and status response elasticsearch#97700Adding
detailsmetadata to the_clusterssection of both async and synchronous search responses Add specific cluster error info, shard info and additional metadata for CCS when minimizing roundtrips elasticsearch#97731